Subject: | What does it really do? Everything... |
Summary: | Package rating comment |
Messages: | 1 |
Author: | Artur Graniszewski |
Date: | 2010-08-24 07:40:52 |
|
|
|
Artur Graniszewski rated this package as follows:
Utility: | Bad |
Consistency: | Insufficient |
Examples: | Insufficient |
|
Artur Graniszewski - 2010-08-24 07:40:52
What does it really do? Everything is hardcoded, and there is probably no real-life case which can be supported by this class.
The code is short, but hard to read:
$view2=strtr($change,$matriz);
$this->allowed=$view2;
return $this->allowed
---
The simple equivalent would be:
return ($this->allowed = strtr($change,$matriz));
Btw,$matriz shold be declared as a public class property, so someone else could change/add sentences to replace.
|