Subject: | Specifying the sql is a bit clumsy... |
Summary: | Package rating comment |
Messages: | 2 |
Author: | F Philip DeGeorge |
Date: | 2009-06-14 18:32:30 |
Update: | 2009-06-15 05:20:04 |
|
|
|
F Philip DeGeorge rated this package as follows:
Utility: | Sufficient |
Consistency: | Good |
Examples: | Good |
|
F Philip DeGeorge - 2009-06-14 18:32:30
Specifying the sql is a bit clumsy (IMHO), but it works, and it's NOT bad, at all. I think the utility would be improved by finding a better (less cryptic) way of specifying the sql (e.g. the find_all() function) for a query. Though this is a problem ultimately in designing any dB class (which I've done often enough to not want to bother any more :) ). Just a suggestion: break the parts of the query up into sub-objects in their own right. FROM tables, JOIN, INNER-JOIN, OUTER-JOIN, FILTER (just the actual filter, not the relationship specs between tables involved in the query), and so. This improves over all utility, in my experience with query objects. Also allows for vastly more complex queries, involving multiple tables or dB objects (views, etc).
Anyway... nice job!
Corey W. - 2009-06-15 05:20:04 - In reply to message 1 from F Philip DeGeorge
Thanks.
Yah, I wanted to do something like that (like the Kohana frameworks DB class), but I decided to just make it way simpler.
|