Subject: | This package looks cool, and I would... |
Summary: | Package rating comment |
Messages: | 6 |
Author: | David van der Sluis |
Date: | 2009-01-15 10:02:55 |
Update: | 2009-01-22 08:02:39 |
|
|
|
David van der Sluis rated this package as follows:
Utility: | Sufficient |
Consistency: | Not sure |
Examples: | Bad |
|
David van der Sluis - 2009-01-15 10:02:55
This package looks cool, and I would use it, but it has way too many flaws:
Calling member variables in the constructor which have not been defined,
not using the variables $TableAlign consistantly as a methodparameter.
Not adding the scope of the methods, is not a bad thing(as some users are using php4), but webhosts should be using php5 anyway.
and oh yeah, html elements should be lowercase.
David van der Sluis - 2009-01-15 10:05:07 - In reply to message 1 from David van der Sluis
And btw: you should be developing with E_ALL and E_STRICT turned on.
You would have "noticed" it.
Hongbo LU - 2009-01-15 10:11:55 - In reply to message 2 from David van der Sluis
same error here. But fortunately, this code problem is easy to correct.
David van der Sluis - 2009-01-15 10:41:53 - In reply to message 3 from Hongbo LU
And So I did, but these errors are very basic and should be being noticed before releasing a package to the public.
F Philip DeGeorge - 2009-01-19 18:18:35 - In reply to message 1 from David van der Sluis
'... the web hosts should be using PHP5 anyway...'
You want to mention that to my webhost? I wish they would upgrade, but they haven't. When I ask them I get a blank, glassy-eyed stare.
David van der Sluis - 2009-01-22 08:02:39 - In reply to message 5 from F Philip DeGeorge
A normal webhost should abandon php because there ar e no updates for it any longer. If they don't want to, then they are too lazy.
If there core application wont run under php5 then they are even more lazy: the date of the last update was known for a long time.
I would consider switching to another host, the more if they ask quite some money.
|