| Subject: | I love that you've developed a way... |
|---|
| Summary: | Package rating comment |
|---|
| Messages: | 2 |
|---|
| Author: | george davidson |
|---|
| Date: | 2010-03-14 03:25:06 |
|---|
| Update: | 2010-03-14 03:44:48 |
|---|
| |
|
|
george davidson rated this package as follows:
| Utility: | Not sure |
|---|
| Consistency: | Good |
|---|
| Examples: | Good |
|---|
|
|
 george davidson - 2010-03-14 03:25:06 I love that you've developed a way to zip up files/directories without relying on PHP's zip functions.
My only major concern is that even the CreateZipFileMac class doesn't seem to create zip files that can be opened on Mac OS X.
One other piece of feedback is I would appreciate that methods like parseDirectory be protected rather than private. That way I can use them from within subclasses of your class.
Keep up the good work!
 Er. Rochak Chauhan - 2010-03-14 03:44:48 - In reply to message 1 from george davidsonThanks a lot George.
I am looking into the Mac issue, the trouble is that it works on some Mac Machines but not all :(
I have made the parseDir function protected as you made a valid point :)
Thank you again for your valuable time and feedback.
Best Regards,
Rochak Chauhan
|
