Recommend this page to a friend! |
Classes of Eric Sizemore | Clock Abstraction | CONTRIBUTING.md | Download |
|
DownloadContributingClock accepts contributions of code and documentation from the community. These contributions can be made in the form of Issues or Pull Requests on the Clock repository. Clock is licensed under the MIT license. When submitting new features or patches to Clock, you are giving permission to license those features or patches under the MIT license. Clock tries to adhere to PHPStan level 9 with strict rules and bleeding edge. Please ensure any contributions do as well. GuidelinesBefore we look into how, here are the guidelines. If your Pull Requests fail to pass these guidelines it will be declined, and you will need to re-submit when you?ve made the changes. This might sound a bit tough, but it is required for me to maintain quality of the code-base. PHP StylePlease ensure all new contributions match the PSR-12 coding style guide. The project is not fully PSR-12 compatible, yet; however, to ensure the easiest transition to the coding guidelines, I would like to go ahead and request that any contributions follow them. DocumentationIf you change anything that requires a change to documentation then you will need to add it. New methods, parameters, changing default values, adding constants, etc. are all things that will require a change to documentation. The change-log must also be updated for every change. Also, PHPDoc blocks must be maintained. Documenting functions/variables (PHPDoc)Please ensure all new contributions adhere to: when documenting new functions, or changing existing documentation. BranchingOne thing at a time: A pull request should only contain one change. That does not mean only one commit, but one change - however many commits it took. The reason for this is that if you change X and Y but send a pull request for both at the same time, we might really want X but disagree with Y, meaning we cannot merge the request. Using the Git-Flow branching model you can create new branches for both of these features and send two requests. |